This project is read-only.
5
Vote

Settings not saving.

description

Line 106 of Settings.ascx.vb
Dim datClosingDate As Date = Convert.ToDateTime(DBNull.Value)
 
Causes the error is and exits the save procedure.

comments

abecommis wrote Jul 25, 2011 at 9:08 AM

I'm having this error and can't find the solution. I tried looking at the source but no .vb file existing. How can I solve this?

wrote Jul 28, 2011 at 9:08 AM

robertjcollins wrote Aug 5, 2011 at 7:47 PM

We have released a new version 04.70.01 RC (in the download section of this site) that resolves this issue. Once it has passed our formal testing it will be updated to the Stable Release version, but for now you will have to manually select this version form downloads and then download the install.

wrote Nov 29, 2011 at 1:37 PM

AbelB wrote Nov 29, 2011 at 2:03 PM

I can confirm that the fix works. Not sure why impact was recorded as "low", as without this seemingly small bug, it was impossible to do anything.

Actually, there's an over-optimization in the DefaultSurveyResultsTemplate method. If loads a fixed template string, and than saves it. I'd like to suggest to turn this into a property and not save it, only call it when for some reason the database-stored value is not available. This fits the no-side-effects rule of properties, settings, constants and fields.

In this particular case, it prevents changing the value in the database, as every other time, this will be overwritten with the default setting of DefaultSurveyResultsTemplate...

wrote Dec 22, 2011 at 5:45 PM

wrote Feb 14, 2013 at 7:59 PM